Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1CEEF19F49 for ; Fri, 8 Apr 2016 16:52:08 +0000 (UTC) Received: (qmail 77028 invoked by uid 500); 8 Apr 2016 16:52:07 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 76989 invoked by uid 500); 8 Apr 2016 16:52:07 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 76973 invoked by uid 99); 8 Apr 2016 16:52:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 16:52:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 753DBDFDE0; Fri, 8 Apr 2016 16:52:07 +0000 (UTC) From: morioma To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie... Content-Type: text/plain Message-Id: <20160408165207.753DBDFDE0@git1-us-west.apache.org> Date: Fri, 8 Apr 2016 16:52:07 +0000 (UTC) Github user morioma commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-207511327 I prefer this one to https://github.com/apache/cordova-plugin-camera/pull/197, because that one has code duplication for calculating rotation. I am thinking getting rid of the ```getImageOrientation``` function all together and use the ```getRotatedBitmap``` from ```processResultFromCamera``` which based on the EXIF helper. Additionally, the issue may not just for android 4.4. Latest Android 6.0.1 on a Galaxy S6 edge suffers the same issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org