Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-420-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-420-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-10921 Emit warning in case of
 plugin ...
Content-Type: text/plain
Message-Id: <20160408140433.ED8E1DFC74@git1-us-west.apache.org>
Date: Fri,  8 Apr 2016 14:04:33 +0000 (UTC)

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/420#discussion_r59029064
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {
     
                                 if (missingVariables.length) {
                                     shell.rm('-rf', pluginInfo.dir);
    +                                events.emit('verbose', 'Removing ' + pluginInfo.dir + ' due to installation failure');
                                     var msg = 'Variable(s) missing (use: --variable ' + missingVariables.join('=value --variable ') + '=value).';
    --- End diff --
    
    What I'm suggesting is to remove the change at L160 and replacing it by ```events.emit(msg)``` because:
    - The plugin isn't getting removed since it hasn't been installed in the first place
    - It lets the user know the reason why the plugin won't be installed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org