cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ephemer <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...
Date Thu, 28 Apr 2016 16:46:08 GMT
GitHub user ephemer opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8

    CB-11074: Ensure settings from config.xml are taken into consideration

    #7 also addresses this issue but in my tests didn't work.
    
    This pull request presents a workaround that requires two WKWebView instances to be inited
(only one is kept and used for the app though). This isn't supposed to be merged as is, it's
more a proof of concept and designed to provide exposure to the workaround if others users
need this fix urgently.
    
    @shazron the logic presented in this PR would have been made more complicated via the
updateWithInfo: method, which as far as I could see is unused, so I removed it for now. Other
than that, what do you think about this as general direction.
    
    As I commented in #7, the best approach for this would be to change `CDVViewController.m`
to pass in the settings directly on init, or to rearrange the check logic there. That is a
longer-term solution. In the meantime, maybe we can get by with the approach presented here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ephemer/cordova-plugin-wkwebview-engine master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit b87ad79a12af05c9a14559dd3f1d8e658493c27c
Author: Geordie J <geojay@gmail.com>
Date:   2016-04-28T16:39:17Z

    CB-11074: Ensure settings from config.xml are taken into consideration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message