cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akofman <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...
Date Wed, 13 Apr 2016 09:51:25 GMT
GitHub user akofman opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7

    Fixes CB-11074: WKWebView configuration is not considered

    I updated the configuration before the WKWebView initialisation in order to consider it.
    It implies that the updateWithInfo method doesn't update it anymore. I'm not sure it is
really a problem but I'd prefer @shazron to confirm.
    
    Thanks for the reviews !

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akofman/cordova-plugin-wkwebview-engine master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 18219a0fe66208cc3ff1a794908510194cf86668
Author: Alexis Kofman <alexis.kofman@gmail.com>
Date:   2016-04-13T09:46:45Z

    Fixes CB-11074: WKWebView configuration is not considered

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message