cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...
Date Mon, 11 Apr 2016 21:40:08 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-lib/pull/425

    CB-10986: Adding support for scoped npm package plugins

    Apparently pre 6.1.0 versions of the CLI were able to add scoped npm packages, but I don't
think we ever supported that feature (if it ever worked, I'm sure it was very error prone).
This adds support for npm scoped packages. Some notes about the implementation:
    
    * Scoped npm packages, once installed, should be identified by the plugin ID and not the
whole scoped package spec. That means if you run `cordova plugin add @scope/cordova-plugin-camera`,
the entry that appears in `cordova plugin ls` will be `cordova-plugin-camera` without the
scope. If you wanted to remove the plugin, you would run `cordova plugin remove cordova-plugin-camera`
(again without the scope)
    * Scoped npm packages cannot be installed side by side with their un-scoped counterparts
(but I'm not sure why you would want to do that anyway)
    * Scoped plugin entries in `config.xml` populate the spec field in this format: `@scope/plugin-id@version`
whereas un-scoped plugins just give the version
    
    I am afraid this may conflict somewhat with cordova-fetch (but I am unsure).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-10986

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #425
    
----
commit 139bd323c0f6ce74ed17b2e865cd7c3e177052a7
Author: Richard Knoll <richard.b.knoll@gmail.com>
Date:   2016-04-07T17:57:28Z

    CB-10986: Adding support for scoped npm package plugins

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message