cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony-- <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-6992 Fix non-working create case, add...
Date Tue, 12 Apr 2016 12:45:07 GMT
GitHub user tony-- opened a pull request:

    https://github.com/apache/cordova-ios/pull/216

    CB-6992 Fix non-working create case, add new test

    Added name normalization from prepare to createProject in order to support the case where
the user edits name in config.xml, then adds ios platform to project.
    
    Also added a new test since the existing test was passing.  The new test used a different
unicode string. It fails without this fix and passes with this fix.
    
    Please see [this JIRA comment](https://issues.apache.org/jira/browse/CB-6992?focusedCommentId=15237088&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15237088)
for additional background info.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tony--/cordova-ios CB6992-platform-api-create

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit c2a4ebbf81f3b088bb00ebaf499e0068337ff6ab
Author: Tony Homer <tony.homer@intel.com>
Date:   2016-04-11T20:27:59Z

    CB-6992 Fix non-working create case, add new test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message