cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ephemer <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...
Date Thu, 21 Apr 2016 20:27:20 GMT
GitHub user ephemer opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162

    CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView thread

    Presenting a UIViewController in front of the main Cordova UIViewController containing
a WKWebView causes the WKWebView thread to block entirely. This means that the OAuth login
flow pauses on a blank screen on success, which is bad for the user experience that falsely
looks like an error has on occurred.
    
    See https://issues.apache.org/jira/browse/CB-11136 for details.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ephemer/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #162
    
----
commit 04091fde737519c149e7ad6316971cb6b490c5b3
Author: Geordie J <geojay@gmail.com>
Date:   2016-04-21T20:22:38Z

    CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView thread

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message