cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarangan12 <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-11043: Android App crashe...
Date Sat, 09 Apr 2016 00:48:21 GMT
GitHub user sarangan12 opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/121

    CB-11043: Android App crashes while trying to save contact with phone numbers array with
deleted values

    If you use delete operator to remove the phone numbers in a phone number array and then
save it, there will be a runtime exception in android. (In iOS it is already working fine).
This fix will resolve the issue in android. 
    
    @nikhilkh @riknoll @rakatyal Can you review and merge this PR?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarangan12/cordova-plugin-contacts CB-11043

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit d38f7cf1fdfa19e1ae72e12f4fc85303e6c9ffc0
Author: Sarangan Rajamanickam <sarajama@microsoft.com>
Date:   2016-04-09T00:43:27Z

    CB-11043: Android App crashes while trying to save contact with phone numbers array with
deleted values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message