cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (Akvelon)" <v-vlk...@microsoft.com>
Subject RE: help with "npm test" for cordova-lib
Date Fri, 29 Apr 2016 12:01:01 GMT
Done. Please see PR [1] and JIRA [2]

This happens due to some caching issues with `getPlatformApi` method which doesn't respect
symlinked paths.
The reason why tests are not failing on Travis and Appveyor is that they run in environments,
where the test directory isn't symlinked. However, on OS X '/var' dir where test directory
is located is a symlink to '/private/var'.

Regarding 'npm run ci' - it calls 'cover' npm task that calls 'jasmine-node spec-cordova spec
plugman' - so in fact we're running the same set of tests as in 'npm test'

-
[1] https://github.com/apache/cordova-lib/pull/433
[2] https://issues.apache.org/jira/browse/CB-11174 

-
Best regards, Vladimir

-----Original Message-----
From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com] 
Sent: Friday, April 29, 2016 9:37 AM
To: dev@cordova.apache.org
Subject: RE: help with "npm test" for cordova-lib

Yeah, I was planning to look into this today.

-
Best regards, Vladimir


-----Original Message-----
From: Shazron [mailto:shazron@gmail.com]
Sent: Friday, April 29, 2016 3:50 AM
To: dev@cordova.apache.org
Subject: Re: help with "npm test" for cordova-lib

Can someone help, perhaps Vladimir who wrote the tests can shed some light on how to fix this
issue?



On Mon, Apr 25, 2016 at 10:57 AM, Carlos Santana <csantana23@gmail.com>
wrote:

> It's jasmine test that is failing [1]
>
> Does this means that jasmine tests are not running in a continuously? 
> Any reason why are they not running in Travis?
>
> I can't figure out what is the test trying to test:
> it('should successfully add a plugin using relative path when running 
> from subdir inside of project',
>
> So I need some help trying to fix it.
>
> [1]:
>
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/spec-cor
> dova/plugin.spec.js#L171
>
>
> On Mon, Apr 25, 2016 at 12:51 PM Jesse <purplecabbage@gmail.com> wrote:
>
> > Travis is running this:
> > - git clone https://github.com/apache/cordova-js --depth 10
> > - cd cordova-lib
> > - npm link ../cordova-js
> > - npm link ../cordova-common
> > - npm link ../cordova-serve
> > - npm install
> > - "(cd ../cordova-common && npm test)"
> > - "npm run ci"
> >
> > There are a lot of different things that could affect the tests, 
> > which cordova-js&|common&|serve you have installed/linked and so on.
> > Travis is essentially doing 'npm run ci' which does not run jasmine, 
> > so
> the
> > issue is probably a failing jasmine test.
> > Can you try running 'npm run ci' and seeing if that passes?
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Sat, Apr 23, 2016 at 1:53 PM, Carlos Santana 
> > <csantana23@gmail.com>
> > wrote:
> >
> > > I do't get it then, Travis is green, so Travis not running same 
> > > test
> > suite
> > > as "npm test"?
> > >
> > > On Fri, Apr 22, 2016 at 9:11 PM Shazron <shazron@gmail.com> wrote:
> > >
> > > > I'm seeing the same. Using node 0.12.7
> > > >
> > > >
> > > > On Fri, Apr 22, 2016 at 12:44 PM, Carlos Santana <
> csantana23@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > I'm seeing 2 test failures when I do "npm test"
> > > > >
> > > > > Anyone seeing the same? Wonder what I have setup wrong here:
> > > > >
> > > > > Here is a paste
> > > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%
> > > > > 2fpastebin.com%2f4E4c40X5&data=01%7c01%7cv-vlkoti%40microsoft.
> > > > > com%7c0b976f09a98748ccaf1c08d36fc84313%7c72f988bf86f141af91ab2
> > > > > d7cd011db47%7c1&sdata=05hD%2f6dwDQ7y4Vgxfx9eYsrzZnHuXFe2pwFIY9
> > > > > P92wQ%3d of my output
> > > > >
> > > > > I thought it was node 5, but then swift to node 4 and the same.
> > > > > This is after making sure all npm links are correct with "coho
> > > npm-link"
> > > > >
> > > >
> > >
> >
>
Mime
View raw message