cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdonst <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Sat, 30 Apr 2016 00:36:45 GMT
Github user macdonst commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464
  
    @ktop @riknoll yeah, config.xml should be part of this. Anything in config.xml should
trump whatever is specified in the plugin.xml. If we do modes then default mode would be `add`,
if nothing to `replace` then it becomes an `add` and `delete` could take out the entire element.
We can work on flags later but getting attribute level manipulation into config.xml and plugin.xml
parsing would be amazing.
    
    @purplecabbage you need to add:
    
    ```
    <config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
        <application android:name="MyApplication" android:isGame="true" />
        <uses-sdk android:maxSdkVersion="22" />
    </config-file>
    ```
    
    into the plugin.xml of a plugin you are including in the project. So...
    
    ```
    cordova create newproject 
    cordova platform add android
    cordova plugin add cordova-plugin-one-I-just-made-up
    // modified the plugin.xml with the fragment from above
    cordova prepare
    // checked androidmanifest.xml for changes
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message