cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Date Sat, 30 Apr 2016 00:05:52 GMT
Github user jasongin commented on the pull request:

    https://github.com/apache/cordova-lib/pull/429#issuecomment-215911697
  
    @nikhilkh As we discussed, this workaround was the best I could find. The command script
approach has similar performance to just copying files via the node fs APIs, and it correctly
copies the file times, enabling incremental builds to work correctly. My biggest remaining
concern is any errors during the copy will not pinpoint a specific file, but that should be
an extremely rare issue.
    
    I also tried using a generated PowerShell script to just update the file times after copying
in nodejs, but that was too slow, both in PS startup cost and per-file cost.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message