cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Fri, 29 Apr 2016 20:08:15 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-215866756
  
    @ktop config-file wasn't in config.xml before, but we wanted to add it because the number
of config.xml attributes that just edit various native xml files is getting unsustainable.
I think that config.xml's config-file modifications should happen during the same step as
the plugins' modifications do, but they should definitely be applied after all of the plugin.xml
ones. That way, the app developer always has the option to override whatever the plugins are
doing.
    
    I think the mode flag is a good idea, but I worry about allowing it in plugin.xml. If
plugins are able to do things other than add elements, does that mean we have the opportunity
for plugins to overwrite each other's modifications depending on the order in which their
config-file attributes are resolved? That might get weird. Definitely makes sense to have
it in config.xml though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message