cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Fri, 29 Apr 2016 19:38:59 GMT
Github user ktop commented on the pull request:
    I had Edna test the first time around before I opened the PR and she was able to get it
working, so that is weird that it is adding a new element for you. 
    Was config-file functional in config.xml before? Or was that something to be done as part
of this jira issue? I was only focused on getting it working in plugin.xml, so I can work
on it if it isn't implemented yet. Should config.xml handle config-file during prepare?
    The mode suggestion sounds good. It will give users a lot of utility for modifying xml
    I have just few clarification questions: 
    - If no mode is specified, is the default to add?
    - For replace, if there is nothing to replace, should it still try to add?
    - And for delete, should it delete an element even if the element has children?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message