cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdonst <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Fri, 29 Apr 2016 17:01:38 GMT
Github user macdonst commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-215811240
  
    @ktop Yeah, I have the `attr="true"` in my plugin.xml and it still gets added instead
of merged.
    
    ```
    <config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
        <application android:name="MyApplication" android:isGame="true" />
        <uses-sdk android:maxSdkVersion="22" />
    </config-file>
    ```
    
    I'm not sure why it's not working for me 😢 
    
    Regardless, I have some other comments. What if I put config-file statements in config.xml?
Which change takes precedence?
    
    Also, instead of using `attr="true"` would it make more sense to use a more granular approach
like `mode="add|replace|merge|delete"` where:
    
    - add will append to the inner xml of the parent
    - replace will completely overwrite the parent's inner xml with your declaration
    - merge will attempt to find elements of the same name and merge their attributes
    - delete will search for elements matching the specified name and attributes and delete
them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message