cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...
Date Thu, 28 Apr 2016 22:51:11 GMT
Github user shazron commented on the pull request:
    I also commented on #7. 
    To solve this problem, instead of having to instantiate WKWebView twice here, I think
we can safely move all initializing code from the initWithFrame, to pluginInitialize:
-- all we need to do is save the CGRect for the frame for later. At this point, with this
approach, the WKWebView will have been instantiated for this return call:
    As I mentioned in #7, we still need updateWithInfo.
    The rest of your approach is sound.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message