cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...
Date Thu, 28 Apr 2016 22:43:55 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215584737
  
    @ephemer not just settings (which as you said will probably not a frequent scenario),
but setting the other delegates. updateWithInfo will be used for certain apps that need to
set their own delegates on the webViewEngines -- a minor case, but I encountered this just
last week.
    
    I don't think self.webViewEngine will fail in the case of your 'preferred approach' you
mentioned since that is just the CDVPlugin object wrapper that will always be instantiated
unless WKWebView is not available: https://github.com/apache/cordova-plugin-wkwebview-engine/blob/33a75172a1450e8922788cd23382cc6ec33845c7/src/ios/CDVWKWebViewEngine.m#L47-L49
    
    I'll comment on your #8 pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message