cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-11166 Added an Appium tes...
Date Thu, 28 Apr 2016 17:34:13 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61469221
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -133,7 +136,7 @@ describe('Contacts Android', function () {
         function renameContact(oldName, newGivenName, newFamilyName) {
             return driver
                 .context(webviewContext)
    -            .setAsyncScriptTimeout(4 * MINUTE)
    +            .setAsyncScriptTimeout(7 * MINUTE)
    --- End diff --
    
    Right now updating a contact on our osx-android builder takes a long time (around 5 minutes).

    As it is a minor tweak I thought it's OK to include it with another commit.
    I'm not sure though that it is a good idea to just increase timeout instead of investigating
what's wrong with the simulator on the slave.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message