cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-plugin-contacts pull request: CB-11166 Added an Appium tes...
Date Thu, 28 Apr 2016 17:31:29 GMT
Github user riknoll commented on a diff in the pull request:
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -114,14 +116,15 @@ describe('Contacts Android', function () {
    -            .executeAsync(function (pID, cb) {
    +            .executeAsync(function (pID, getOnlyBirthday, cb) {
    --- End diff --
    Okay, that's fine then. It might be better to just always return a contact object but
convert the birthday to a string so that the function always returns the same type.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message