cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-11166 Added an Appium tes...
Date Thu, 28 Apr 2016 17:24:04 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61467646
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -114,14 +116,15 @@ describe('Contacts Android', function () {
                 })
                 .click()
                 .context(webviewContext)
    -            .executeAsync(function (pID, cb) {
    +            .executeAsync(function (pID, getOnlyBirthday, cb) {
    --- End diff --
    
    Why do you need to pass the `getOnlyBirthday` flag? Is there an issue with just always
returning the full contact and checking the birthday field as part of the birthday spec?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message