cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swbradshaw <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...
Date Thu, 28 Apr 2016 02:29:02 GMT
GitHub user swbradshaw reopened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/197

    CB-4078: correctOrientation not working on camera.getPicture for PHOTOLIBRARY

    This fixes the orientation bug for Android 4.4+ devices when choosing a picture from the
photo library.
    
    This fixes both DATA_URL and FILE_URI requests.
    
    Tested on Android 4.0.4,  Android 5.02, and Android 5.1 devices.
    
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swbradshaw/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #197
    
----
commit f2b4eeded069d791aec0670b369bab8fb3bfd0eb
Author: swbradshaw <swbradshaw@gmail.com>
Date:   2016-04-28T02:27:37Z

    CB-4078: Fix for orientation/scaling on Android 4.4+ devices
    
    The only way to get rotation for photos in library (Gallery, File
    System, Google Drive,etc) is to first create a temporary file from the
    provider. Only then can we determine the orientation and scale the
    bitmap correctly. By doing it in a central place, it eliminates reading
    the inputstream repetitively in the plugin.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message