cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ephemer <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...
Date Tue, 26 Apr 2016 17:54:29 GMT
Github user ephemer commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214827853
  
    Thank you, my pleasure.
    
    I have thought about this a bit longer.. The main issue is that recent Cordova changes,
namely introducing WKWebView, have broken this plugin for a significant use case, namely OAuth.
The changes suggested here put the functionality back to how it was before the internal changes
broke it. I'd prefer a different solution but until we have that I think it's important that
the plugin does what it's supposed to.
    
    Making these changes depend on an option like `modal: false` is a bit like providing the
option `worksAsItIsSupposedTo: true`. If anything we could provide an option `useStrictlyModalBrowser:
true` or similar to opt-in to the new WKWebView behaviour.
    
    @jcesarsh what do you think, looking at this in that light?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message