cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdonst <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Date Fri, 22 Apr 2016 17:25:23 GMT
Github user macdonst commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-213519895
  
    @ktop I did a quick test of this with one of my existing apps and it does add the following
lines to AndroidManifest.xml:
    
    ```
        <application android:isGame="true" android:name="MyApplication" />
        <uses-sdk android:maxSdkVersion="22" />
    ```
    
    but unfortunately it already had the following lines:
    
    ```
        <application android:hardwareAccelerated="true" android:icon="@drawable/icon" android:label="@string/app_name"
android:supportsRtl="true">
        <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="23" />
    ```
    
    So in order for this to get merged it has to be able to modify existing lines instead
of adding new ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message