cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarangan12 <>
Subject [GitHub] cordova-docs pull request: CB-11127 Improving internal linking
Date Fri, 22 Apr 2016 17:07:04 GMT
Github user sarangan12 commented on a diff in the pull request:
    --- Diff: www/.htaccess ---
    @@ -61,14 +63,14 @@ RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/latest$ {{site.baseurl}}/docs/$1/latest/
     #     docs/*/XX/* -> docs/*/YY/*
    -{% for redirect in %}RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/{{redirect.old}}/(.*)$
{{site.baseurl}}/docs/$1/{{}}/$2 [R=302,L]
    +{% for redirect in %}RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/{{redirect[0]}}/(.*)$
{{site.baseurl}}/docs/$1/{{redirect[1]}}/$2 [R=302,L]
    --- End diff --
    NitPick: Alignment. Whouldn't this be better 
    {% for redirect in %}
                   RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/{{redirect[0]}}/(.*)$ {{site.baseurl}}/docs/$1/{{redirect[1]}}/$2

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message