cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
Date Thu, 21 Apr 2016 22:26:33 GMT
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/96#discussion_r60665206
  
    --- Diff: lib/util.js ---
    @@ -81,8 +92,8 @@ module.exports = (function() {
             return numDevices;
         }
     
    -    function getSimId() {
    -        var findSimCommand = "cordova run --list --emulator | grep ^iPhone | tail -n1";
    +    function getSimId(localCLI) {
    --- End diff --
    
    Can't we get the localCLI here by just calling getlocalCLI() instead of having to pass
it to updatepermissions and then to getSimId?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message