cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ephemer <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...
Date Thu, 21 Apr 2016 21:18:30 GMT
Github user ephemer commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-213118009
  
    I agree that it feels kind of wrong.
    
    The problem is that many users (myself included) have no control over the call site for
window.open - this Cordova and it's meant to be cross-platform; adding arbitrary Cordova-specific
options into window.open for public OAuth packages seems worse in my eyes. I guess we could
wrap window.open in our own wrapper function but none of this seems ideal.
    
    Other than the fact it's not the normal iOS way of doing things, is there anything fundamentally
problematic with the approach in this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message