cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarsh <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...
Date Thu, 21 Apr 2016 21:11:42 GMT
Github user jcesarsh commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-213116268
  
    I don't think it's a good idea to switch from presenting a modal view to adding a subview,
it might behave differently in some cases.
    Maybe adding a new "modal" option being "yes" as default so users will have the same behavior
and the ones with CB-11136 problem can use the "modal=no" 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message