cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <>
Subject [GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Date Wed, 20 Apr 2016 17:08:38 GMT
Github user jasongin commented on a diff in the pull request:
    --- Diff: cordova-common/src/FileUpdater.js ---
    @@ -0,0 +1,389 @@
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +"use strict";
    +var fs = require("fs");
    +var path = require("path");
    +var shell = require("shelljs");
    +var minimatch = require("minimatch");
    + * Updates a target file or directory with a source file or directory. (Directory updates
    + * not recursive.) Stats for target and source items must be passed in. This is an internal
    + * helper function used by other methods in this module.
    + *
    + * @param {string|null} rootDir Root directory (such as a project) to which target and
    --- End diff --
    I was aware of that syntax (and used it for the [log] parameter here). But my interpretation
was that it was for parameters that could be omitted by the caller, not merely parameters
that could be null. The JSDoc documentation isn't clear about that, but everywhere else I've
seen the brackets used was where the parameter could be omitted.
    In reply to: [60384873](
[](ancestors = 60384873)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message