cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Date Wed, 20 Apr 2016 12:27:01 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-common/src/FileUpdater.js ---
    @@ -0,0 +1,389 @@
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +"use strict";
    +var fs = require("fs");
    +var path = require("path");
    +var shell = require("shelljs");
    +var minimatch = require("minimatch");
    + * Updates a target file or directory with a source file or directory. (Directory updates
    + * not recursive.) Stats for target and source items must be passed in. This is an internal
    + * helper function used by other methods in this module.
    + *
    + * @param {string|null} rootDir Root directory (such as a project) to which target and
    + *     path parameters are relative, or null if the paths are absolute. The rootDir is
    + *     from any logged paths, to make the logs easier to read.
    + * @param {string} targetPath Destination file or directory to be updated. If it does
not exist,
    + *     it will be created.
    + * @param {fs.Stats|null} targetStats An instance of fs.Stats for the target path, or
null if
    + *     the target does not exist.
    + * @param {string|null} sourcePath Source file or directory to be used to update the
    + *     destination. If the source is null, then the destination is deleted if it exists.
    + * @param {fs.Stats|null} sourceStats An instance of fs.Stats for the source path, or
null if
    + *     the source does not exist.
    + * @param {boolean} force If target and source are both files, and the force flag is
    + *     set, then the file will not be copied unless the source is newer than the target.
    + * @param {function} [log] Optional logging callback that takes a string message describing
    + *     file operations that are performed.
    + * @return {boolean} true if any changes were made, or false if the force flag is not
    + *     and everything was up to date
    + */
    +function updatePathWithStats(
    +        rootDir, targetPath, targetStats, sourcePath, sourceStats, force, log) {
    +    log = log || function(message) { };
    --- End diff --
    Also, do we need to pass logging callback to every method? According to the example usage
at the methods of `FileUpdater ` are called
several times so it might make sense to make this class constructable ans set up logging via
constructor parameter.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message