cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-paramedic pull request: Code changes for Collecting Device...
Date Tue, 19 Apr 2016 22:01:35 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/4#discussion_r60320027
  
    --- Diff: main.js ---
    @@ -37,6 +39,30 @@ if (pathToParamedicConfig || // --config
             ParamedicConfig.parseFromFile(pathToParamedicConfig):
             ParamedicConfig.parseFromArguments(argv);
     
    +    if(argv.plugin) {
    +        paramedicConfig.setPlugins(argv.plugin);
    +    }
    +
    +    if(argv.outputDir) {
    +        paramedicConfig.setOutputDir(argv.outputDir);
    +    }
    +
    +    if(argv.logMins) {
    +        paramedicConfig.setLogMins(argv.logMins);
    +    }
    +
    +    if(argv.tccDbPath){
    --- End diff --
    
    Do you assume the tccDbPath exists? Perhaps you validate somewhere else - should you instead
validate here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message