cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...
Date Tue, 19 Apr 2016 16:14:26 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/428#discussion_r60261791
  
    --- Diff: cordova-lib/src/cordova/restore-util.js ---
    @@ -112,7 +112,10 @@ function installPluginsFromConfigXML(args) {
             // assume it is the location to install from.
             var pluginSpec = pluginEntry.spec;
             pluginName = pluginEntry.name;
    -        var installFrom = semver.validRange(pluginSpec, true) ? pluginName + '@' + pluginSpec
: pluginSpec;
    +        var installFrom = (pluginSpec && semver.validRange(pluginSpec, true))
?
    --- End diff --
    
    This is a complex ternary - consider break into and if else as it will make it simpler
to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message