cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-11084 CameraUsesGeolocation=true fo...
Date Tue, 19 Apr 2016 10:50:52 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/92#discussion_r60209862
  
    --- Diff: medic/medic-appium.js ---
    @@ -222,6 +223,37 @@ function getLocalCLI(appPath) {
         return "./cordova";
     }
     
    +function getConfigPath(appPath) {
    +    return path.join(appPath, "config.xml");
    +}
    +
    +function parseElementtreeSync(filename) {
    +    var contents = fs.readFileSync(filename, util.DEFAULT_ENCODING);
    +    if(contents) {
    --- End diff --
    
    If the file is empty the rest of the code is not valid anymore. Maybe throw an exception
here if there is `!contents`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message