cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...
Date Mon, 18 Apr 2016 17:40:59 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-211493781
  
    It still needs to be able to update it dynamically. I would refactor it to not remove
the existing code, but create a new `- (WKWebViewConfiguration*) createConfigurationFromSettings:(NSDictionary*)settings;`
    
    That way it can be used in both updateSettings and initWithFrame


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message