cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-paramedic pull request: Code changes for Collecting Device...
Date Fri, 15 Apr 2016 16:44:11 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/4#discussion_r59903675
  
    --- Diff: lib/ParamedicLog.js ---
    @@ -0,0 +1,154 @@
    +#!/usr/bin/env node
    +
    +/* jshint node: true */
    +
    +"use strict";
    +
    +var shelljs  = require("shelljs");
    +var fs       = require("fs");
    +var path     = require("path");
    +var util     = require('./utils').utilities;
    +var logger   = require('./utils').logger;
    +
    +
    +function ParamedicLog(platform, appPath, logPath){
    +    this.platform = platform;
    +    this.appPath = appPath;
    +    this.logPath = logPath;
    +}
    +
    +ParamedicLog.prototype.logIOS = function (appPath) {
    +    // We need to print out the system log for the simulator app. In order to figure
    +    // out the path to that file, we need to find the ID of the simulator running
    +    // mobilespec
    +
    +    // First, figure out the simulator that ran mobilespec. "cordova run"" just chooses
    --- End diff --
    
    I find this to be very fragile code because it depends on internal implementation details
of ```cordova run --list```. Those could well change in the future. I think it  might be better
to just copy the logic that deals with listing the simulators in this project.
    What do you think ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message