cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-paramedic pull request: Code changes for Collecting Device...
Date Thu, 14 Apr 2016 17:57:31 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762195
  
    --- Diff: lib/ParamedicKill.js ---
    @@ -0,0 +1,95 @@
    +#!/usr/bin/env node
    +
    +"use strict";
    +
    +var shelljs = require("shelljs");
    +var util    = require("./utils").utilities;
    +var logger  = require('./utils').logger;
    +
    +function ParamedicKill(platform) {
    +    this.platform = platform;
    +}
    +
    +ParamedicKill.prototype.kill = function() {
    +    // shell config
    +    shelljs.config.fatal  = false;
    +    shelljs.config.silent = false;
    +
    +    // get platform tasks
    +    var platformTasks = this.tasksOnPlatform(this.platform);
    +
    +    if (platformTasks.length < 1) {
    +        console.warn("no known tasks to kill");
    --- End diff --
    
    in this case, we want to stop processing and bail out of the ```kill``` function.
    Please, add a ```return``` statement here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message