cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8383 Handle pause event when keep...
Date Wed, 13 Apr 2016 22:27:05 GMT
Github user infil00p commented on the pull request:

    https://github.com/apache/cordova-android/pull/288#issuecomment-209673913
  
    This does not work, since all actions on a WebView thread MUST happen on the UI thread.
 Also, you don't actually start the thread at all and this patch breaks the pause/resume functionality
of KeepRunning entirely.
    
    Adding a thread just for the sake of adding a thread is generally a bad idea, especially
when you have to pause something that runs on the UI thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message