cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <>
Subject [GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...
Date Wed, 13 Apr 2016 16:51:56 GMT
Github user jasongin commented on a diff in the pull request:
    --- Diff: src/ios/CDVCamera.m ---
    @@ -358,6 +358,7 @@ - (NSData*)processImage:(UIImage*)image info:(NSDictionary*)info options:(CDVPic
                     // use image unedited as requested , don't resize
                     data = UIImageJPEGRepresentation(image, 1.0);
                 } else {
    +                data = UIImageJPEGRepresentation(image, [options.quality floatValue]
/ 100.0f);
                     if (options.usesGeolocation) {
    --- End diff --
    When using the "unedited" image above, the geolocation option is ignored -- is that correct
behavior? Or should the if (options.usesGeolocation) be moved to outside/after the else block?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message