cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...
Date Tue, 12 Apr 2016 17:12:59 GMT
Github user riknoll commented on the pull request:
    @vladimir-kotikov To clarify the plugin mapper comments: I left in the scope with the
intention that the mapping would fail if the scope was present. I don't think there is a case
for remapping old plugin ids that have a scope added, because if you are giving a scope then
you know what npm package you are trying to fetch. We should never remap in that scenario
and I'll try and clarify that in the code. As for changing the API, I'm fine with the approach
you suggested (separate class, one function, etc.). I think I just dug myself into a hole
with the initial way I wrote the code and didn't refactor when I should have :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message