cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...
Date Tue, 12 Apr 2016 09:55:38 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/425#issuecomment-208825623
  
    As a general comment, i'd love to see the methods for dealing with plugin spec returning
a structured result instead of an array. This IMO would make the code more readable, as it's
really hard to follow, what e.g. `parseRegistryPluginSpec(target)[0]` means.
    
    Also, factoring this into a separate class could help to improve readability. Something
like `PluginSpec.parse(target).version`is much more easy to understand, at least personally
for me :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message