cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...
Date Tue, 12 Apr 2016 09:16:27 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -410,6 +422,9 @@ function getPluginVariables(variables){
     function getVersionFromConfigFile(plugin, cfg){
    +    if (cordova_util.isScopedRegistryPluginSpec(plugin)) {
    --- End diff --
    Should we chack for this before calling `extractPluginId`? From what i understand, `extractPluginId`
will return id without scope even if plugin spec contains scope expression.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message