cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...
Date Tue, 12 Apr 2016 08:31:21 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/425#discussion_r59339185
  
    --- Diff: cordova-lib/src/cordova/util.js ---
    @@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
             });
         });
     }
    +
    +/**
    + * Extracts the name and spec from an npm style package spec that follows the
    + * format of (@scope/)?package(@spec)?
    + * @param {String} raw  The raw npm style package spec
    + * @returns {String[]}  An array containing the package name with optional scope
    --- End diff --
    
    IMO returning an array is not very convenient to use. This leads to guessing, what is
the 0th item of the result in the expressions like `cordova_util.parseRegistryPluginSpec(target)[0]`.
I'd prefer to use structured result. something like `npm-package-arg` returns (https://github.com/npm/npm-package-arg#examples)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message