cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...
Date Mon, 11 Apr 2016 22:57:38 GMT
Github user jasongin commented on the pull request:

    https://github.com/apache/cordova-lib/pull/423#issuecomment-208603032
  
    OK, I didn't realize config file transformations were also done already in plugin add.
And I think I have a better understanding of the code now.
    
    My understanding is we still need to do prepare for any platforms which don't do the following
things:
     1. Implement the PlatformApi
     2. Copy over the plugins' www files in addPlugin()
     3. Return true from addPlugin()
    
    So do we also need changes to iOS and Windows platforms to do 2 and 3, to match what you
did for Android in the linked PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message