cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...
Date Mon, 11 Apr 2016 12:26:19 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/420#discussion_r59195085
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {
     
                                 if (missingVariables.length) {
                                     shell.rm('-rf', pluginInfo.dir);
    +                                events.emit('verbose', 'Removing ' + pluginInfo.dir +
' due to installation failure');
                                     var msg = 'Variable(s) missing (use: --variable ' + missingVariables.join('=value
--variable ') + '=value).';
    --- End diff --
    
    I think if we add the change below then we will have exactly the same message to be traced
twice. The pic above with log trace sample looks good.
    
    > I think we should also emit a message about the variables missing.(events.emit(msg))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message