cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elsewhat <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...
Date Sat, 09 Apr 2016 16:17:51 GMT
Github user elsewhat commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207814319
  
    @riknoll @nikhilkh as an app developer I have to disagree with you.
    I would **expect a framework such as cordova to never crash an app under no circumstances
if it's preventable**.
    Crashing an app is a very significant event which impacts users perception of the app
very negatively and causes a significant effort wrt. end-user support for enterprise apps.
It will in many cases cause entered data to be lost, and nothing frustrates users more.
    
    There is lots the app can do to handle such an exception. In my case I can make sure the
users understand the issue is because the size of the image and how they can perform workarounds.

    
    Ideally, the CameraLauncher.failPicture would allow me to pass some semantics regarding
the nature of the issue for example an error code. But since this was not in place already
in the code, I didn't do any changes to it. 
    
    However, **I totally agree that refactoring the code to reduce the memory footprint is
an even better approach which actually tackles the root cause. But this doesn't negate the
need to avoid OutOfMemoryErrors when performing memory intensive operations**. Even with an
exceptionally optimized memory handling of images in cordova-camera-plugin there will always
be situations where an OutOfMemoryError occurs, for example if the app uses a lot of memory
on the webview side and the device is old with a strict limit on heap size (a G1 had 16MB
of heap)
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message