cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From morioma <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...
Date Fri, 08 Apr 2016 16:52:07 GMT
Github user morioma commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-207511327
  
    I prefer this one to https://github.com/apache/cordova-plugin-camera/pull/197, because
that one has code duplication for calculating rotation.
    I am thinking getting rid of the ```getImageOrientation``` function all together and use
the ```getRotatedBitmap``` from ```processResultFromCamera``` which based on the EXIF helper.
    
    Additionally, the issue may not just for android 4.4. Latest Android 6.0.1 on a Galaxy
S6 edge suffers the same issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message