cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...
Date Fri, 08 Apr 2016 16:28:10 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/165#discussion_r59051696
  
    --- Diff: template/cordova/lib/ConfigParser.js ---
    @@ -73,6 +73,15 @@ WindowsConfigParser.prototype.getWindowsTargetVersion = function()
{
         return preference;
     };
     
    +WindowsConfigParser.prototype.getUAPTargetMinVersion = function() {
    +    var preference = this.getPreference('uap-target-min-version');
    +
    +    if (!preference)
    --- End diff --
    
    Nit: code style: It just best to always add curlies for blocks - indentation based on
editor tabs and other things can sometimes cause errors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message