cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...
Date Thu, 07 Apr 2016 23:57:34 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58963991
  
    --- Diff: README.md ---
    @@ -354,6 +354,35 @@ for details.
         // remove the contact from the device
         contact.remove(onSuccess,onError);
     
    +### Removing phone number(s) from a saved contact
    +
    +    var myContact = navigator.contacts.create({"displayName": "Test User"});
    +    var phoneNumbers = [];
    +
    +    phoneNumbers[0] = new ContactField('work', '768-555-1234', false);
    +    phoneNumbers[1] = new ContactField('mobile', '999-555-5432', true); // preferred
number
    +    phoneNumbers[2] = new ContactField('home', '203-555-7890', false);
    +
    +    myContact.phoneNumbers = phoneNumbers;
    +    myContact.save(function (contact_obj) {
    --- End diff --
    
    I would say it might be nicer to search for a contact and update it rather than creating
a new one that immediately gets updated. A more realistic scenario


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message