cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...
Date Mon, 04 Apr 2016 21:22:00 GMT
Github user jcesarmobile commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205502326
  
    Ok, so we should change 
    ```
    String fileName = realPath != null ?
                realPath.substring(realPath.lastIndexOf('/') + 1) :
                "modified." + (this.encodingType == JPEG ? "jpg" : "png");
    ```
    As realPath will not be null anymore it doesn't make any sense.
    
    We have some options:
    Detect if the fileName have an extension, if not, then use the "modified"... approach.
    Try to get the real image name, I think that's possible even for Google Drive images.
    
    Any other ideas?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message