cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...
Date Mon, 04 Apr 2016 18:39:59 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205441624
  
    Okay, finally got around to testing this on Jelly bean and I found an issue: content URIs
don't always end in a file type (like .jpg). We try and get the filename in `ouputModifiedBitmap`
from `getRealPath` (see [here](https://github.com/elsewhat/cordova-plugin-camera/blob/CB-10857cordova-plugin-camera/src/android/CameraLauncher.java#L600))
and so we end up writing to a temporary image without a file extension. I don't know if we
make assumptions like that anywhere else, but we need to address that before merging this.
Reproducing camera options:
    ```
    {
            mediaType: Camera.MediaType.PICTURE,
            destinationType: Camera.DestinationType.FILE_URI,
            sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
            quality: 50,
            allowEdit: false,
            encodingType: 0,
            correctOrientation: true
            saveToPhotoAlbum: true
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message