Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F084F1845A for ; Tue, 8 Mar 2016 20:00:11 +0000 (UTC) Received: (qmail 74076 invoked by uid 500); 8 Mar 2016 20:00:11 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 74042 invoked by uid 500); 8 Mar 2016 20:00:11 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 74030 invoked by uid 99); 8 Mar 2016 20:00:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Mar 2016 20:00:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ECF0918060A for ; Tue, 8 Mar 2016 20:00:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.679 X-Spam-Level: * X-Spam-Status: No, score=1.679 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, JMQ_TRACKER=0.5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3kLKUMTtFwyi for ; Tue, 8 Mar 2016 20:00:08 +0000 (UTC) Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 051935FAC4 for ; Tue, 8 Mar 2016 20:00:08 +0000 (UTC) Received: by mail-qk0-f181.google.com with SMTP id x1so10885495qkc.1 for ; Tue, 08 Mar 2016 12:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=wQHcSY5e7MXzkdDyp72/7ggja+5GBHiPDQmLkiRKVSU=; b=hk95D+FWNLfnQREJpVf+DUfqaGgfXiZNWjDmFzDmnG9sJJq1ocpY4Dra3G88Mk1Lrm DTYb0N1rQk1aQPcGLSPx6lskLaFxbTjjxG3Axs6ePs5x+xugXDiFbfptqZnu9YORnAn0 ekOX938w9U8r2GUq5Dtt/ezARo5WsqpVirwujwXUDnN3P2tEHHY386V6Q9NsDLcRNvEA GaS25A5il83UxbhSaEos1pD/OuzmtAgjldWKDx+bhp510R8fHf3moXJKe354MXfXHjHV wAo1wKTTTxWwf4K78S9rwNasgbYaKcfLG4wLy0C5wxsbMVnBhNocUlQER3/7IUs53fYv 51Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=wQHcSY5e7MXzkdDyp72/7ggja+5GBHiPDQmLkiRKVSU=; b=joSRqRHDu+F1MeBr845uMWumxt2E6dmVYUEGBmccA1XIUrzuszc94BrVFhkR5SJQKl eAeLFhkgvmyaBOWJi4R/3NB2BxmI5/j2rodtOEQhiN0mhYcdGJUPNze9kQxy7ZRDV2Yh zx0LxnSY4GtlvaqpuQBBcx5UaY1qeKna2GfOnHVdHk/P3o0QhtfQAbnJuZdPVbWyjRCK VLwyIEwPMEPicfPD+GYwoDMibXqrrIoytuKQcQT+cO27eDOmnkiH54oPTcg/TrZfXMfn C5O3NwzwCfLUJ2mbnSeaAxXsh3E+zymaPdMc0Js2u0g9gW315LZJXfNaj748QvitwcvG JA/A== X-Gm-Message-State: AD7BkJIk7gwmXrT5/Isyn/V6nPs/9TC35xZUaonRlMeOIKk9qbwA/ChiKtNae1Upfw0eSSShTB3vJE7U/OXGlQ== MIME-Version: 1.0 X-Received: by 10.55.71.135 with SMTP id u129mr38850819qka.26.1457467207052; Tue, 08 Mar 2016 12:00:07 -0800 (PST) Received: by 10.140.105.203 with HTTP; Tue, 8 Mar 2016 12:00:06 -0800 (PST) In-Reply-To: References: Date: Tue, 8 Mar 2016 21:00:06 +0100 Message-ID: Subject: Re: Making plugins backward compatible to 5.1.1 From: julio cesar sanchez To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=001a114a7d2025f8ad052d8f075b --001a114a7d2025f8ad052d8f075b Content-Type: text/plain; charset=UTF-8 I already said on the jira issue that I preffer not to add this. And cordova iOS 4.X.X breaks on iOS 6 and older, so it's a matter of time that you will have to update to cordova iOS 4 and you won't be able to support that versions. But the truth is the PR is very simple and won't make any harm to add it. It will need the changes I commented on the issue. 2016-03-08 20:01 GMT+01:00 Steven Gill : > Personally, I'm not a fan of adding/keeping legacy code for platforms we > don't support. > > On Tue, Mar 8, 2016 at 9:09 AM, Thomas Allen wrote: > > > I opened ticket CB-10631 regarding the "Device" plugin that didn't work > > when I built my app for iOS 5.1.1. I was asked by user jcesarmobile to > send > > an email to discuss. > > > > https://issues.apache.org/jira/browse/CB-10631 > > > > Basically I submitted a patch to allow the plugin to work with iOS 5.1.1. > > You can see in my description what I've done and how it works using > Cordova > > 5.4.1. > > > > I'm not suggesting the Cordova project support iOS 5.1.1, but the > question > > is whether the project should explicitly reject code that is used to > make a > > plugin backward compatible. > > > > I have an app on the app store that uses Cordova 5.4.1, compiled using > > Xcode 6.4, with the patch that I submitted for this plugin, and it works > > fine on iPad 1 on 5.1.1, iPad 2 on iOS 7 and iPad Air on iOS 8. > > > > > > *Thomas Allen* > > ceo | agilelaw > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Fagilelaw.com%2F&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > | address > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Fgoo.gl%2Fmaps%2FUzxyg&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > > > o 512.348.6525 x101 > > m 512.587.3692 > > > > facebook | twitter > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Ftwitter.com%2F%23!%2Fagilelaw&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > | linkedin > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Flinkedin.com%2Fcompany%2Fagilelaw&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > > --001a114a7d2025f8ad052d8f075b--