Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: Dan Polivy <dan@cellartracker.com>
To: "'dev@cordova.apache.org'" <dev@cordova.apache.org>
Subject: [DISCUSS] browserify not pulling correct platform cordova-js-src
Thread-Topic: [DISCUSS] browserify not pulling correct platform cordova-js-src
Thread-Index: AdF2Ya34tAjEZOjuRqyff3s1+UZ8cQ==
Date: Fri, 4 Mar 2016 22:10:21 +0000
Message-ID: 
 <277c6490ee3b4b80b44d0a365f021120@EXBE008SV3.NA02.MSEXCHANGEOUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_277c6490ee3b4b80b44d0a365f021120EXBE008SV3NA02MSEXCHANG_"
MIME-Version: 1.0

--_000_277c6490ee3b4b80b44d0a365f021120EXBE008SV3NA02MSEXCHANG_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi folks,

I've recently updated my projects to the latest platform releases to pick u=
p some specific fixes in the platform JS (android@5.1.1 and ios@4.1.0). I'm=
 using the browserify option, and have been trying to figure out why the br=
owserify output is NOT including those fixes in the final compiled cordova.=
js. After doing some digging, it seems that by default (with cordova@6.0.0)=
 the cordova-js/tasks/lib/bundle-browserify.js code is pulling from the glo=
bal npm repository instead of the actual project root:

\\AppData\\Roaming\\npm\\node_modules\\cordova\\node_modules\\cordova-lib\\=
node_modules\\cordova-js\\src\\

Instead of

\\platforms\\android\\platform_www\\cordova-js-src\\

As a result, the compiled cordova.js has the right PLATFORM_VERSION_BUILD_L=
ABEL, but the wrong contents. It seems this is fixed by this commit:

https://github.com/apache/cordova-lib/commit/28e8b33f6bb84b3e056cf71600e3c4=
719139061f

I was going to file a bug on this, but since it is already resolved, I figu=
red I would just raise it here and confirm 1) the "fixed" behavior is corre=
ct, and 2) when would this fix make it out into the wild? Hopefully this do=
esn't bite too many others in the meantime!

Dan


--_000_277c6490ee3b4b80b44d0a365f021120EXBE008SV3NA02MSEXCHANG_--